Skip to content

Reconfigure limit_val_batches only for int#8099

Merged
athitten merged 2 commits intomainfrom
athitten/fix_reconfigure_val_batches
Jan 2, 2024
Merged

Reconfigure limit_val_batches only for int#8099
athitten merged 2 commits intomainfrom
athitten/fix_reconfigure_val_batches

Conversation

@athitten
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Abhishree <abhishreetm@gmail.com>
@github-actions github-actions bot added the NLP label Dec 29, 2023
@athitten
Copy link
Collaborator Author

athitten commented Jan 2, 2024

jenkins

@athitten
Copy link
Collaborator Author

athitten commented Jan 2, 2024

jenkins

1 similar comment
@athitten
Copy link
Collaborator Author

athitten commented Jan 2, 2024

jenkins

@athitten athitten requested a review from ShriyaRishab January 2, 2024 21:41
Copy link
Collaborator

@layalir layalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shriya P. tested and said it works.

@athitten athitten merged commit d3c5896 into main Jan 2, 2024
@athitten athitten deleted the athitten/fix_reconfigure_val_batches branch January 2, 2024 22:48
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants