Merged
Conversation
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
…A/NeMo into add_text_metrics_evaluator
Signed-off-by: stevehuang52 <heh@nvidia.com>
…etrics_evaluator
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
| ) | ||
| if gt_text_attr_name not in sample: | ||
| if "text" in sample: | ||
| gt_text_attr_name = "text" |
Check notice
Code scanning / CodeQL
Unused local variable
| f"ground-truth text attribute {pred_text_attr_name} is not present in manifest! Cannot calculate {metric}. Returning!" | ||
| ) | ||
| if "text" in sample: | ||
| gt_text_attr_name = "text" |
Check notice
Code scanning / CodeQL
Unused local variable
Collaborator
Author
|
jenkins |
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> * fix bleu eval Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> * fix bleu eval Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> * fix bleu eval Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bleu calculation for ASR evaluator