Skip to content

Restore PTQ tests for Llama2 (reopened)#9064

Merged
ericharper merged 3 commits intomainfrom
jlasek/ptq_tests_reopen
May 1, 2024
Merged

Restore PTQ tests for Llama2 (reopened)#9064
ericharper merged 3 commits intomainfrom
jlasek/ptq_tests_reopen

Conversation

@janekl
Copy link
Collaborator

@janekl janekl commented Apr 30, 2024

What does this PR do ?

See #9018 (reopened here due to CICD setup)

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

There's no need to comment jenkins on the PR to trigger Jenkins CI.
The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@github-actions github-actions bot added the CI label Apr 30, 2024
@janekl janekl added Run CICD and removed CI labels Apr 30, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl force-pushed the jlasek/ptq_tests_reopen branch from d949757 to e9685c0 Compare April 30, 2024 06:20
@github-actions github-actions bot added the CI label Apr 30, 2024
@janekl janekl added Run CICD and removed Run CICD labels Apr 30, 2024
Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: eharper <eharper@nvidia.com>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit e267406 into main May 1, 2024
@ericharper ericharper deleted the jlasek/ptq_tests_reopen branch May 1, 2024 17:54
suiyoubi pushed a commit that referenced this pull request May 2, 2024
* Restore PTQ tests for Llama2 (MR-9018)

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* try not using release

Signed-off-by: eharper <eharper@nvidia.com>

* checkout v4

Signed-off-by: eharper <eharper@nvidia.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: eharper <eharper@nvidia.com>
Co-authored-by: eharper <eharper@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
@janekl janekl mentioned this pull request May 6, 2024
8 tasks
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Restore PTQ tests for Llama2 (MR-9018)

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* try not using release

Signed-off-by: eharper <eharper@nvidia.com>

* checkout v4

Signed-off-by: eharper <eharper@nvidia.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: eharper <eharper@nvidia.com>
Co-authored-by: eharper <eharper@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants