Lhotse dataloading: RIR augmentation and nemo/tarred input support for RIR and noise aug#9109
Merged
Lhotse dataloading: RIR augmentation and nemo/tarred input support for RIR and noise aug#9109
Conversation
…r RIR and noise aug Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from omegaconf import DictConfig, OmegaConf | ||
|
|
||
| from nemo.collections.common.data.lhotse.cutset import read_cutset_from_config | ||
| from nemo.collections.common.data.lhotse.cutset import guess_parse_cutset, read_cutset_from_config |
Check notice
Code scanning / CodeQL
Cyclic import
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
|
|
||
| It's intended to be used in a generic context where we are not sure which way the user will specify the inputs. | ||
| """ | ||
| from nemo.collections.common.data.lhotse.dataloader import make_structured_with_schema_warnings |
Check notice
Code scanning / CodeQL
Cyclic import
KunalDhawan
approved these changes
May 3, 2024
| # III) common options | ||
| keep_excessive_supervisions: bool = True # when a cut is truncated in the middle of a supervision, should we keep them. | ||
| # e. RIR augmentation (synthetic RIR if rir_path is None) | ||
| # at the moment supports only Lhotse recording manifests, e.g. https://github.com/lhotse-speech/lhotse/blob/master/lhotse/recipes/rir_noise.py |
Collaborator
There was a problem hiding this comment.
Just opening a discussion thread here, would be great to support other alternatives in the future
Collaborator
Author
There was a problem hiding this comment.
Yes, I'll aim to follow up shortly on this. I'll need to release a new lhotse version that extends the API to support CutSet RIR inputs first (as NeMo manifests can be adapted to that), and didn't want to block this work for that.
FWIW constructing a recording set is a one-liner from lhotse import RecordingSet; RecordingSet.from_dir("my-rirs", pattern="*.wav").to_file("rirs.jsonl.gz")
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…r RIR and noise aug (NVIDIA-NeMo#9109) * Lhotse dataloading: RIR augmentation and nemo/tarred input support for RIR and noise aug Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix for RIR: currently lhotse requires RecordingSet Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Unit tests and fixes Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Unit test for RIR Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Extensions in Lhotse dataloading augmentations:
Collection: ASR
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information