Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
WalkthroughAdds installation notes about libibverbs-dev for deep_ep when installing vLLM outside containers. README gains a note and shell snippet; pyproject.toml gains comment lines under the vllm dependency section. No code, dependency, or build behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (1)
108-113: Add cross‑distro note for non‑Debian systems.Improves portability for RHEL/CentOS/Rocky users.
Apply this diff to append a brief tip:
If you encounter problems when installing vllm's dependency deep_ep on bare-metal (outside of a container), you may need to install libibverbs-dev as well. Here is how you can install it: ```sh sudo apt-get update sudo apt-get install libibverbs-dev+> [!TIP]
+> On RHEL/CentOS/Rocky Linux, install the equivalent development package:
+>sudo dnf install rdma-core-devel</blockquote></details> <details> <summary>pyproject.toml (1)</summary><blockquote> `71-73`: **Prefer docs over shell command comments in pyproject.** Keeping install commands in README avoids drift and keeps pyproject clean. Replace with a pointer to the README section. Apply this diff: ```diff - # deep_ep also needs libibverbs-dev - # sudo apt-get update - # sudo apt-get install libibverbs-dev + # DeepEP build on bare-metal requires libibverbs headers; see README ("Bare-metal prerequisites for vLLM/DeepEP").
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Lint check
🔇 Additional comments (1)
README.md (1)
108-113: LGTM: Clear guidance for DeepEP on bare‑metal.Helpful addition; matches common DeepEP/rdma-core headers requirement outside containers.
Signed-off-by: Yuki Huang <yukih@nvidia.com>
As title.
Summary by CodeRabbit