ci: Remove test comment from automodel integration check#1148
ci: Remove test comment from automodel integration check#1148chtruong814 merged 1 commit intomainfrom
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
WalkthroughThe GitHub Actions workflow .github/workflows/_automodel_integration_check.yml was updated to stop pre-initializing the comment_body output. The workflow now emits comment_body and creates the related artifact only if prior steps appended content, altering artifact creation when no issues are detected. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions Runner
participant Checks as Checks/Analysis Steps
participant Out as Outputs Stage
participant Art as Artifact Upload
GH->>Checks: Run integration checks
Checks-->>Out: Append findings to comment_body (if any)
rect rgba(200,235,255,0.25)
note over Out: Changed behavior
Out->>Out: Evaluate comment_body
alt comment_body has content
Out-->>GH: Emit comment_body output
GH->>Art: Create/upload comment artifact
else comment_body empty
Out-->>GH: No comment_body emitted
GH--x Art: Skip artifact creation
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
…#1148) Signed-off-by: Charlie Truong <chtruong@nvidia.com>
What does this PR do ?
Remove test comment from automodel integration check. I accidentally left that in this PR https://github.com/NVIDIA-NeMo/RL/pull/1028/files
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit