Skip to content

ci: Remove test comment from automodel integration check#1148

Merged
chtruong814 merged 1 commit intomainfrom
chtruong/fix-automodel-msg
Sep 18, 2025
Merged

ci: Remove test comment from automodel integration check#1148
chtruong814 merged 1 commit intomainfrom
chtruong/fix-automodel-msg

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Sep 17, 2025

What does this PR do ?

Remove test comment from automodel integration check. I accidentally left that in this PR https://github.com/NVIDIA-NeMo/RL/pull/1028/files

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Updated integration check workflow to stop pre-populating review comments. Comments and related artifacts are now generated only when issues are detected, reducing PR noise and avoiding empty artifacts.
    • No changes to the checks themselves or their messaging; behavior only affects when comments/artifacts appear.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Walkthrough

The GitHub Actions workflow .github/workflows/_automodel_integration_check.yml was updated to stop pre-initializing the comment_body output. The workflow now emits comment_body and creates the related artifact only if prior steps appended content, altering artifact creation when no issues are detected.

Changes

Cohort / File(s) Summary
Workflow: automodel integration check
\.github/workflows/_automodel_integration_check.yml
Removed default test initialization of comment_body; output and artifact are now conditionally produced only when content exists. No other logic or messaging altered.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions Runner
  participant Checks as Checks/Analysis Steps
  participant Out as Outputs Stage
  participant Art as Artifact Upload

  GH->>Checks: Run integration checks
  Checks-->>Out: Append findings to comment_body (if any)

  rect rgba(200,235,255,0.25)
  note over Out: Changed behavior
  Out->>Out: Evaluate comment_body
  alt comment_body has content
    Out-->>GH: Emit comment_body output
    GH->>Art: Create/upload comment artifact
  else comment_body empty
    Out-->>GH: No comment_body emitted
    GH--x Art: Skip artifact creation
  end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In the workflow burrow, tidy and bright,
I nibbled out defaults, trimmed with delight.
No crumbs, no comments, when all checks are clean—
Only speak up when findings are seen.
Hop-hop! Artifacts skip on a breeze,
Silence is golden in CI trees. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "ci: Remove test comment from automodel integration check" is concise and accurately reflects the primary change described in the PR (removing an accidental test comment from the automodel integration check); it uses a clear conventional-commit prefix and is specific enough for teammates to understand the main intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chtruong/fix-automodel-msg

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a9f7ac and 051d2a5.

📒 Files selected for processing (1)
  • .github/workflows/_automodel_integration_check.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/_automodel_integration_check.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint check
  • GitHub Check: Post automodel integration comment / Comment on PR
  • GitHub Check: Post submodule check comment / Comment on PR

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the CI Relating to CI label Sep 17, 2025
@terrykong terrykong added this pull request to the merge queue Sep 17, 2025
@chtruong814 chtruong814 removed this pull request from the merge queue due to the queue being cleared Sep 18, 2025
@chtruong814 chtruong814 merged commit 95b7326 into main Sep 18, 2025
26 checks passed
@chtruong814 chtruong814 deleted the chtruong/fix-automodel-msg branch September 18, 2025 02:14
yfw pushed a commit that referenced this pull request Sep 23, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
…#1148)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants