Skip to content

Conversation

@terrykong
Copy link
Contributor

@terrykong terrykong commented Oct 2, 2025

What does this PR do ?

The datasets dir in gitignore now incorrectly ignores the subpackage nemo_rl/data/datasets. This restricts the ignore to the top level.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Updated repository ignore configuration to target only the top-level datasets directory, altering which dataset-related paths are tracked in version control.
    • No changes to application behavior, UI, or APIs; end users will not see any differences in functionality.
    • Build and runtime artifacts remain unaffected, ensuring consistent file tracking across environments.

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong requested a review from chtruong814 October 2, 2025 04:53
@terrykong terrykong requested a review from a team as a code owner October 2, 2025 04:53
@terrykong terrykong enabled auto-merge (squash) October 2, 2025 04:53
@terrykong terrykong added the CI:docs Run doctest label Oct 2, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

📝 Walkthrough

Walkthrough

Updated .gitignore to change the ignore pattern for the datasets directory from a recursive match to a repository-root-specific entry, affecting which dataset paths are ignored.

Changes

Cohort / File(s) Summary
Git ignore rules
`.gitignore`
Adjusted ignore pattern for `datasets/` from recursive to root-level scope, limiting ignores to top-level `datasets/` only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately conveys that the .gitignore update restricts ignoring to only the top-level datasets directory, directly reflecting the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Test Results For Major Changes ✅ Passed The PR makes a single narrow adjustment to the repository’s .gitignore to limit the ignored datasets directory to the top level, which is a minor configuration change and does not introduce new features, break existing behavior, or risk performance or convergence regressions, so absence of test results in the description is acceptable under the check criteria.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tk/datasets-ignore

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d82ca75 and 9b664d7.

📒 Files selected for processing (1)
  • .gitignore (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: CI quality check
  • GitHub Check: Docs_Tests
  • GitHub Check: Lint check
  • GitHub Check: Lint check
  • GitHub Check: Post submodule check comment / Comment on PR
  • GitHub Check: Post automodel integration comment / Comment on PR
🔇 Additional comments (1)
.gitignore (1)

36-36: Root-anchoring datasets/ fixes subpackage ignores.

Adding the leading slash scopes the ignore to the repo root so nemo_rl/data/datasets stays tracked while the top-level dataset artifacts remain ignored. Matches the intended behavior—thanks.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong terrykong merged commit d653437 into main Oct 2, 2025
54 of 56 checks passed
@terrykong terrykong deleted the tk/datasets-ignore branch October 2, 2025 13:04
chtruong814 pushed a commit that referenced this pull request Oct 2, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants