Skip to content

chore: 0.4.0.rc0 -> 0.4.0#1297

Merged
chtruong814 merged 1 commit intor0.4.0from
chtruong/remove-rc0
Oct 7, 2025
Merged

chore: 0.4.0.rc0 -> 0.4.0#1297
chtruong814 merged 1 commit intor0.4.0from
chtruong/remove-rc0

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Oct 7, 2025

What does this PR do ?

chore: 0.4.0.rc0 -> 0.4.0

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Promoted package from release candidate to stable release. The version string no longer includes the “rc” suffix (e.g., 1.x.y instead of 1.x.yrc0).
    • Users will see the updated version in package metadata, CLI/version outputs, and logs.
    • Improves compatibility with tooling expecting final releases and may affect dependency resolution and PyPI packaging tags.
    • No functional changes to features or behavior.

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner October 7, 2025 04:24
@chtruong814 chtruong814 added the CI:docs Run doctest label Oct 7, 2025
@chtruong814 chtruong814 enabled auto-merge (squash) October 7, 2025 04:24
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

📝 Walkthrough

Walkthrough

The pre-release indicator in nemo_rl/package_info.py was changed from "rc0" to an empty string, altering computed version strings (shortversion and version). No other logic, control flow, or constants were modified.

Changes

Cohort / File(s) Summary of edits
Version metadata
nemo_rl/package_info.py
Set PRE_RELEASE from "rc0" to "". Updated derived __shortversion__/__version__ formatting as a consequence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

CI:docs

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change of bumping the version from 0.4.0.rc0 to 0.4.0, clearly reflecting the update made in the package_info.py file.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Test Results For Major Changes ✅ Passed The PR only updates the package pre-release indicator from “rc0” to a final release string, which is a minor versioning change and does not alter functionality or introduce major refactors, so tests are not required by the custom check for this scenario.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chtruong/remove-rc0

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7536be3 and b71865d.

📒 Files selected for processing (1)
  • nemo_rl/package_info.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Follow the Google Python Style Guide for all Python code
Target Python 3.12+ for all Python code in NeMo-RL
Indent Python code with 4 spaces; do not use tabs
Python filenames should be snake_case (e.g., some_file.py)
Class names should be PascalCase
Function and method names should be snake_case
Local variable names should be snake_case; if starting with a number, prefix with k (e.g., k_99th_percentile)
Global variables should be UPPER_SNAKE_CASE and prefixed with G_ (e.g., G_MY_GLOBAL)
Constants should be UPPER_SNAKE_CASE
Avoid shadowing variables declared in an outer scope
Initialize all externally visible members of a class in the constructor
For public interfaces used outside a file, prefer docstrings over comments
Use comments mainly for code within a function or interfaces local to a file
Commented-out code must include a nearby comment explaining usage and why it is commented out; otherwise remove before merging
Use Google-style docstrings for classes and functions (Sphinx-parseable)
Avoid using reflection when functionality can be easily achieved without it
Limit except clauses to the smallest specific set of exceptions possible
For duck-typing via try/except, keep the try body minimal and use else for main logic
Add the NVIDIA copyright header (with current year) at the top of all Python files, excluding tests/ and test-only scripts

Files:

  • nemo_rl/package_info.py
nemo_rl/**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

nemo_rl/**/*.py: Do not set non-None configuration defaults in code; YAML is the single source of truth for defaults
Access required config attributes directly (e.g., policy_cfg["precision"]) and assume presence; do not introduce hidden defaults
Express configuration optionality via TypedDict using typing.NotRequired
When adding a new config key to a TypedDict subclass, document the key’s purpose, valid values/types, and recommended default in code
For any class or function decorated with @ray.remote, add '# pragma: no cover' on the class/def line (and on remote functions)

Files:

  • nemo_rl/package_info.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Docs_Tests
  • GitHub Check: sphinx-build / Build docs
  • GitHub Check: Lint check
  • GitHub Check: Lint check
  • GitHub Check: Post submodule check comment / Comment on PR
  • GitHub Check: Post automodel integration comment / Comment on PR
🔇 Additional comments (1)
nemo_rl/package_info.py (1)

19-19: LGTM: Version bump correctly implemented.
Changing PRE_RELEASE from "rc0" to "" finalizes __version__ as 0.4.0, and pyproject.toml dynamically picks up this value.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chtruong814 chtruong814 merged commit 82ab565 into r0.4.0 Oct 7, 2025
41 of 42 checks passed
@chtruong814 chtruong814 deleted the chtruong/remove-rc0 branch October 7, 2025 05:44
terrykong added a commit that referenced this pull request Nov 19, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
terrykong added a commit that referenced this pull request Nov 19, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants