refactor: unify entrypoint for different envs#1841
Merged
Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
github-actions
bot
added
the
documentation
Contributor
|
LGTM! Thanks for your hard work on PR prep. |
terrykong
approved these changes
Feb 3, 2026
Contributor
terrykong
left a comment
terrykong
left a comment
There was a problem hiding this comment.
great work cleaning this up! always good to see more deletions than additions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some dataset refactor work, we can load envs from configs instead of hardcoding in entrypoint now.
run_grpo_rm.pyandrun_grpo_math.pyare exactly the same asrun_grpo.pyexcept the default config yaml.This PR remove them and make env decoupled with entrypoint script.