chore: bumpup Megatron-Bridge submodule to main#2039
Conversation
bedab04 to
3a26b67
Compare
📝 WalkthroughWalkthroughUpdates the Megatron-Bridge submodule pointer from commit f91542b90908ad08b7e13672feea03e27bedee27 to commit 383b610dca1fe553346b37fc0172f54917b02069. No functional code changes—only the submodule reference is updated. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ac9fa35 to
dd5f479
Compare
It is as expected as current branch uses cherry-picked fix commits. |
|
/ok to test dd5f479 |
|
/ok to test a522794 |
❌ Submodule Fast-Forward Check FailedCheck based on commit: a522794 (PR #2039 from ✅ Submodules that are properly updated:Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
❌ Submodule Fast-Forward Check FailedCheck based on commit: a8fa0ff (PR #2039 from ✅ Submodules that are properly updated:Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
|
/ok to test a8fa0ff |
|
/ok to test 56b8508 |
❌ Submodule Fast-Forward Check FailedCheck based on commit: 56b8508 (PR #2039 from ✅ Submodules that are properly updated:Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
|
/ok to test ab73597 |
❌ Submodule Fast-Forward Check FailedCheck based on commit: ab73597 (PR #2039 from ✅ Submodules that are properly updated:Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
…t-llama3.1-8b-1n8g-fsdp2tp4-dynamicbatch Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
32220d2 to
77a4b2c
Compare
❌ Submodule Fast-Forward Check FailedCheck based on commit: 32220d2 (PR #2039 from ✅ Submodules that are properly updated:Automodel: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
❌ Submodule Fast-Forward Check FailedCheck based on commit: 77a4b2c (PR #2039 from ✅ Submodules that are properly updated:Automodel: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
|
/ok to test 77a4b2c |
Signed-off-by: Yuki Huang <yukih@nvidia.com>
|
/ok to test b8f5647 |
❌ Submodule Fast-Forward Check FailedCheck based on commit: b8f5647 (PR #2039 from ✅ Submodules that are properly updated:Automodel: ✅ PR branch is ahead of main branch (fast-forward) ❌ Submodules that need attention:Megatron-Bridge: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
yuki-97
left a comment
There was a problem hiding this comment.
all nightly tests passed, could be merged.
CI:L1 passed in 77a4b2c in https://github.com/NVIDIA-NeMo/RL/actions/runs/23774491454/job/69279367064.
only scripts changes in b8f5647 after that, so run with CI:docs
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com>
What does this PR do ?
Oncall responsibility, regularly bump up Megatron-Bridge/Megatron-LM dependency:
add
gradient_accumulation_fusion: falseto address the following issue:dsv3 style model defaults gradient_accumulation_fusion to true in mbridge:
gradient_accumulation_fusion=true: https://github.com/NVIDIA-NeMo/Megatron-Bridge/pull/2696/commitsIssues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit