Conversation
github-actions
bot
added
the
documentation
Collaborator
Author
github-actions
bot
added
CI
SahilJain314
previously approved these changes
Jul 23, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
Looks good to me, happy to merge. (I assume you need to remove the example that's causing the failed lint check)
Collaborator
Author
|
oh actually, it fails b/c i fixed a few more typing issues and forgot to add them to the whitelist to prevent regressions. let me add the new ones |
SahilJain314
previously approved these changes
Jul 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
terrykong
force-pushed
the
tk/pyrefly
branch
2 times, most recently
from
3ae204b to
ac56050
Compare
terrykong
added
CI:L0
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
SahilJain314
approved these changes
Jul 28, 2025
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
wedu-nvidia
pushed a commit
to wedu-nvidia/RL
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
jiemingz
pushed a commit
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #667
Switches us to pyrefly from mypy which now allows us to static type check as part of pre-commit!
I've included all the files that I've fixed so as of this PR 75/98 files have 0 errors. I've added those to the whitelist to track regressions in static typing in those files. Once we've addressed all typing issues, we can just glob match the core code.
Additionally, there's a CI job that will fail if there's 0 errors and it's not in the whitelist. This helps us prevent regressions and move strictly to better coverage