Skip to content

ci: Enforce code coverage#694

Merged
chtruong814 merged 5 commits intomainfrom
chtruong/codecov
Jul 24, 2025
Merged

ci: Enforce code coverage#694
chtruong814 merged 5 commits intomainfrom
chtruong/codecov

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Jul 18, 2025

What does this PR do ?

  • Enforce code coverage
  • Ensure code coverage files are combined

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@chtruong814
Enforce codecov threshold
e958ce8 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@github-actions github-actions bot added the CI Relating to CI label Jul 18, 2025
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI Relating to CI labels Jul 18, 2025
@chtruong814
Combine unit test coverage report
c51e338 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@github-actions github-actions bot added the CI Relating to CI label Jul 18, 2025
@chtruong814 chtruong814 changed the title Enforce code coverage ci: Enforce code coverage Jul 18, 2025
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels Jul 18, 2025
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels Jul 18, 2025
@chtruong814
Fix unit test code cov append
332be93 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested review from ko3n1g and terrykong July 18, 2025 23:36
chtruong814
chtruong814 commented Jul 18, 2025
View reviewed changes
@chtruong814
Enforce 80% codecov on patch changes
01e1dae 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@terrykong terrykong enabled auto-merge July 23, 2025 21:51
@terrykong terrykong added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@chtruong814 chtruong814 added this pull request to the merge queue Jul 24, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 24, 2025
@chtruong814
ci: Enforce code coverage (#694)
5b0fade 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@ko3n1g ko3n1g added this pull request to the merge queue Jul 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@chtruong814 chtruong814 enabled auto-merge July 24, 2025 12:21
@chtruong814 chtruong814 added this pull request to the merge queue Jul 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@chtruong814 chtruong814 added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 9da6e74 Jul 24, 2025
15 of 16 checks passed
@chtruong814 chtruong814 deleted the chtruong/codecov branch July 24, 2025 15:33
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 28, 2025
@chtruong814 @xxman-google
ci: Enforce code coverage (NVIDIA-NeMo#694)
0c583e6 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
@chtruong814 @rohitrango
ci: Enforce code coverage (#694)
8e43904 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
wedu-nvidia pushed a commit to wedu-nvidia/RL that referenced this pull request Jul 30, 2025
@chtruong814 @wedu-nvidia
ci: Enforce code coverage (NVIDIA-NeMo#694)
cfebbb3 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
@chtruong814 @xxman-google
ci: Enforce code coverage (NVIDIA-NeMo#694)
c48a602 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@chtruong814
ci: Enforce code coverage (NVIDIA-NeMo#694)
1bc5251 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@chtruong814 @xxman-google
ci: Enforce code coverage (NVIDIA-NeMo#694)
9148d26 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
@chtruong814 @soodoshll
ci: Enforce code coverage (NVIDIA-NeMo#694)
ff66961 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
jiemingz pushed a commit that referenced this pull request Aug 20, 2025
@chtruong814
ci: Enforce code coverage (#694)
2c60b9a 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ko3n1g ko3n1g ko3n1g approved these changes

@terrykong terrykong Awaiting requested review from terrykong

Assignees

No one assigned

Labels

CI:L0 Run doctests and unit tests CI Relating to CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chtruong814 @ko3n1g