Skip to content

fix: remove dynamic batching from 8B llama dtensor config#728

Merged
SahilJain314 merged 1 commit intomainfrom
jiemingz/disable_dynamic_batching
Jul 24, 2025
Merged

fix: remove dynamic batching from 8B llama dtensor config#728
SahilJain314 merged 1 commit intomainfrom
jiemingz/disable_dynamic_batching

Conversation

@jiemingz
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
@SahilJain314 SahilJain314 changed the title remove dynamic batch fix: remove dynamic batching from 8B llama dtensor config Jul 23, 2025
Copy link
Contributor

@SahilJain314 SahilJain314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop, missed this earlier

@SahilJain314 SahilJain314 added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 95b0e07 Jul 24, 2025
15 of 18 checks passed
@SahilJain314 SahilJain314 deleted the jiemingz/disable_dynamic_batching branch July 24, 2025 00:04
@terrykong terrykong added the r0.3.0 Release r0.3.0 label Jul 24, 2025
terrykong pushed a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
github-merge-queue bot pushed a commit that referenced this pull request Jul 24, 2025
#736)

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: Jimmy Zhang <133159885+jiemingz@users.noreply.github.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 28, 2025
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
wedu-nvidia pushed a commit to wedu-nvidia/RL that referenced this pull request Jul 30, 2025
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
…o#728)

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
jiemingz added a commit that referenced this pull request Aug 20, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.3.0 Release r0.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants