fix: avoid duplicate bos by adding add_special_tokens=False#747
Merged
fix: avoid duplicate bos by adding add_special_tokens=False#747
Conversation
ZhiyuLi-Nvidia
force-pushed
the
ZhiyuLi-Nvidia-patch-1
branch
from
2f2cddf to
451fe09
Compare
terrykong
reviewed
Jul 28, 2025
terrykong
reviewed
Jul 30, 2025
terrykong
reviewed
Jul 30, 2025
ZhiyuLi-Nvidia
force-pushed
the
ZhiyuLi-Nvidia-patch-1
branch
from
8cdc6b2 to
9d3b325
Compare
terrykong
reviewed
Jul 31, 2025
ZhiyuLi-Nvidia
force-pushed
the
ZhiyuLi-Nvidia-patch-1
branch
from
76a90f4 to
994bdce
Compare
terrykong
previously approved these changes
Aug 2, 2025
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> add tests Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Update tests/unit/data/test_data_processor.py Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> fix Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> fix Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> fix Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> better test/verification Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
ZhiyuLi-Nvidia
force-pushed
the
ZhiyuLi-Nvidia-patch-1
branch
from
994bdce to
ca027e6
Compare
terrykong
previously approved these changes
Aug 2, 2025
ZhiyuLi-Nvidia
force-pushed
the
ZhiyuLi-Nvidia-patch-1
branch
2 times, most recently
from
4caf1c6 to
8420da2
Compare
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> walk around type Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
ZhiyuLi-Nvidia
force-pushed
the
ZhiyuLi-Nvidia-patch-1
branch
from
8420da2 to
6f017e1
Compare
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
terrykong
approved these changes
Aug 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tpoisonooo
pushed a commit
to tpoisonooo/RL
that referenced
this pull request
Aug 4, 2025
…eMo#747) Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
4 tasks
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
…eMo#747) Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…eMo#747) Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information