Skip to content

docs: documentation and unit test for env var precedence#806

Merged
terrykong merged 10 commits intomainfrom
ashors/env-var-precedence
Jul 31, 2025
Merged

docs: documentation and unit test for env var precedence#806
terrykong merged 10 commits intomainfrom
ashors/env-var-precedence

Conversation

@ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jul 30, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

closes #654

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

ashors1 added 5 commits July 30, 2025 13:38
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>

formatting

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 changed the title Add documentation and unit test for env var precedence docs: documentation and unit test for env var precedence Jul 30, 2025
Copy link
Collaborator

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! nice test addition! added @jgerh for doc review

terrykong
terrykong previously approved these changes Jul 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Copy link
Contributor

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed tech pubs review and provided a few copyedits.

ashors1 added 2 commits July 31, 2025 12:14
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@terrykong terrykong added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 26a1078 Jul 31, 2025
15 checks passed
@terrykong terrykong deleted the ashors/env-var-precedence branch July 31, 2025 22:13
tpoisonooo pushed a commit to tpoisonooo/RL that referenced this pull request Aug 4, 2025
…#806)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
…#806)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

document + unit test env_var order of precedence

3 participants