fix: do not remove newlines after final eos_token in data processing#948
Merged
fix: do not remove newlines after final eos_token in data processing#948
Conversation
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
yuki-97
reviewed
Aug 20, 2025
Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com>
yuki-97
approved these changes
Aug 20, 2025
jveronvialard
pushed a commit
that referenced
this pull request
Aug 27, 2025
…948) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 28, 2025
…VIDIA-NeMo#948) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Sep 4, 2025
…VIDIA-NeMo#948) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…VIDIA-NeMo#948) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Currently the data processing will strip the final newline after an eos token which may nudge training to not produce a newline after eos token. The tokenizer that this could be an issue for is qwen which always append a newline after eos_token.
Issues
List issues that this PR closes (syntax):
closes #932
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information