fix: permit conflicting metrics in nightly tests + config code_snapshot dir#954
Merged
fix: permit conflicting metrics in nightly tests + config code_snapshot dir#954
Conversation
…hot dir configurability Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
changed the title
terrykong
changed the title
chtruong814
approved these changes
Aug 20, 2025
jveronvialard
pushed a commit
that referenced
this pull request
Aug 27, 2025
…ot dir (#954) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 28, 2025
…ot dir (NVIDIA-NeMo#954) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Sep 4, 2025
…ot dir (NVIDIA-NeMo#954) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…ot dir (NVIDIA-NeMo#954) Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the metric calculation can error if there is data for the same step in multiple sets of TB logs. This permits this since the usual reason this happens is one stage is pre-empted, so the following stage needs to go back to the last checkpoint so its value is repeated in both the pre-empted TB logs and the new one.
This change also configures the code_snapshot dir which is helpful for versioning runs