chore: ray-sub - improve robustness #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirdey-inflection
changed the title
skirdey-inflection
changed the title
skirdey-inflection
force-pushed
the
ray-sub
branch
from
dff581f to
61ae2b1
Compare
terrykong
reviewed
Aug 22, 2025
Contributor
terrykong
left a comment
terrykong
left a comment
There was a problem hiding this comment.
thanks for making ray.sub better! lots of blood and sweat in this file :) left a comment
we'll test internally and then this should be good
also: @hemildesai to review and update nemo-run template
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
skirdey-inflection
force-pushed
the
ray-sub
branch
from
0997d26 to
037bba2
Compare
terrykong
reviewed
Aug 22, 2025
terrykong
reviewed
Aug 22, 2025
Contributor
terrykong
left a comment
terrykong
left a comment
There was a problem hiding this comment.
other than my awk command, i've tested and lgtm. if addressed we can merge
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Stan Kirdey <stan@inflection.ai>
terrykong
approved these changes
Aug 26, 2025
jveronvialard
pushed a commit
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Stanislav Kirdey <stan@inflection.ai> Signed-off-by: Stan Kirdey <stan@inflection.ai> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Stanislav Kirdey <stan@inflection.ai> Signed-off-by: Stan Kirdey <stan@inflection.ai> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
skirdey-inflection
added a commit
to skirdey-inflection/RL
that referenced
this pull request
Aug 30, 2025
Signed-off-by: Stanislav Kirdey <stan@inflection.ai> Signed-off-by: Stan Kirdey <stan@inflection.ai> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Stanislav Kirdey <stan@inflection.ai> Signed-off-by: Stan Kirdey <stan@inflection.ai> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
Signed-off-by: Stanislav Kirdey <stan@inflection.ai> Signed-off-by: Stan Kirdey <stan@inflection.ai> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When running on slurm, hostname resolution sometimes fails - this PR adds a few fallback methods and debugging info to improve robustness