build: Use no-build-isolation to install deep_gemm to fix arm install#970
Merged
chtruong814 merged 3 commits intomainfrom Aug 25, 2025
Merged
build: Use no-build-isolation to install deep_gemm to fix arm install#970chtruong814 merged 3 commits intomainfrom
chtruong814 merged 3 commits intomainfrom
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
terrykong
previously approved these changes
Aug 23, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
terrykong
approved these changes
Aug 24, 2025
jveronvialard
pushed a commit
that referenced
this pull request
Aug 27, 2025
…#970) Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 28, 2025
…NVIDIA-NeMo#970) Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
skirdey-inflection
pushed a commit
to skirdey-inflection/RL
that referenced
this pull request
Aug 30, 2025
…NVIDIA-NeMo#970) Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Sep 4, 2025
…NVIDIA-NeMo#970) Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…NVIDIA-NeMo#970) Signed-off-by: Charlie Truong <chtruong@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Use no-build-isolation to install deep_gemm to fix arm install
Otherwise, the install fails with a stack trace like this. Inside an arm container, I was able to install deep_gemm with
uv pip install --no-build-isolationAlso, it seems that a PR #859 merged into main that should not have made it through the CI. A Github error happened where the build was skipped, and the CI quality check should have failed but did not. I updated the check to verify the build succeeded when tests are ran and also had to increase the allowed GPU hours for the nightly test suite.
Merge queue that should not have passed:
https://github.com/NVIDIA-NeMo/RL/actions/runs/17169685093/job/48716856164
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information