Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions nemo_run/run/torchx_backend/schedulers/slurm.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,12 +424,24 @@ def _save_job_dir(
)


def _get_job_dirs() -> dict[str, tuple[str, SSHTunnel | LocalTunnel, str]]:
try:
with open(SLURM_JOB_DIRS, "rt") as f:
lines = f.readlines()
except FileNotFoundError:
return {}
def _get_job_dirs(retries: int = 5) -> dict[str, tuple[str, SSHTunnel | LocalTunnel, str]]:
last_exc: OSError | None = None
for _ in range(retries):
try:
with open(SLURM_JOB_DIRS, "rt") as f:
lines = f.readlines()
break
except FileNotFoundError:
return {}
except OSError as e:
last_exc = e
time.sleep(1)
else:
if last_exc is not None:
raise last_exc
raise OSError(
f"Failed to read SLURM job dirs from {SLURM_JOB_DIRS} after {retries} retries"
)

out = {}
for line in lines:
Expand Down
25 changes: 25 additions & 0 deletions test/run/torchx_backend/schedulers/test_slurm.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,31 @@ def test_get_job_dirs():
assert result == {}


def test_get_job_dirs_retries_on_permission_error(tmp_path, mocker):
"""Transient PermissionError should be retried; success on 3rd attempt returns data."""
mocker.patch("time.sleep") # don't actually sleep in tests
mock_open = mocker.mock_open(read_data="")
mock_open.side_effect = [
PermissionError("[Errno 1] Operation not permitted"),
PermissionError("[Errno 1] Operation not permitted"),
mock_open.return_value,
]
mocker.patch("builtins.open", mock_open)

result = _get_job_dirs(retries=5)
assert result == {}
assert mock_open.call_count == 3


def test_get_job_dirs_raises_after_exhausting_retries(mocker):
"""PermissionError should be re-raised after all retries are exhausted."""
mocker.patch("time.sleep")
mocker.patch("builtins.open", side_effect=PermissionError("[Errno 1] Operation not permitted"))

with pytest.raises(PermissionError):
_get_job_dirs(retries=3)


def test_schedule_with_dependencies(slurm_scheduler, slurm_executor):
mock_request = mock.MagicMock()
mock_request.cmd = ["sbatch", "--requeue", "--parsable"]
Expand Down
Loading