Skip to content

feat: add extra_resource_requests and extra_resource_limits to KubeflowExecutor#479

Merged
ko3n1g merged 1 commit intomainfrom
ko3n1g/feat/kubeflow-extra-resources
Apr 6, 2026
Merged

feat: add extra_resource_requests and extra_resource_limits to KubeflowExecutor#479
ko3n1g merged 1 commit intomainfrom
ko3n1g/feat/kubeflow-extra-resources

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Apr 4, 2026

Summary

  • Adds extra_resource_requests and extra_resource_limits fields to KubeflowExecutor
  • Allows users to specify arbitrary Kubernetes resource requests/limits beyond the existing GPU/CPU/memory fields (e.g. rdma/rdma_shared_device_a, hugepages-2Mi, custom device plugins)
  • Both fields are dict[str, str] and are merged into the resource spec after the standard fields

Example

executor = KubeflowExecutor(
    ...
    extra_resource_requests={"rdma/rdma_shared_device_a": "1"},
    extra_resource_limits={"rdma/rdma_shared_device_a": "1"},
)

Test plan

  • Existing tests pass: uv run -- pytest test/
  • Manual e2e test on cluster with custom resource type

🤖 Generated with Claude Code

…owExecutor

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the r0.9.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Apr 4, 2026
@ko3n1g ko3n1g requested a review from hemildesai April 4, 2026 14:08
@ko3n1g ko3n1g merged commit 70ed989 into main Apr 6, 2026
25 checks passed
svcnvidia-nemo-ci pushed a commit that referenced this pull request Apr 6, 2026
…owExecutor (#479)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
ko3n1g added a commit that referenced this pull request Apr 6, 2026
…owExecutor (#479) (#484)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.9.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants