Skip to content

cp: feat: add extra_resource_requests and extra_resource_limits to KubeflowExecutor (479) into r0.9.0 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 1 commit into from
Apr 6, 2026
+4 −0
Merged

cp: feat: add extra_resource_requests and extra_resource_limits to KubeflowExecutor (479) into r0.9.0 #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nemo_run/core/execution/kubeflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ class KubeflowExecutor(Executor):
memory_requests: Optional[str] = None
cpu_limits: Optional[str] = None
memory_limits: Optional[str] = None
extra_resource_requests: dict[str, str] = field(default_factory=dict)
extra_resource_limits: dict[str, str] = field(default_factory=dict)
volume_mounts: list[dict[str, Any]] = field(default_factory=list)
volumes: list[dict[str, Any]] = field(default_factory=list)
labels: dict[str, Any] = field(default_factory=dict)
Expand Down Expand Up @@ -161,6 +163,8 @@ def _build_resources(self) -> dict[str, Any]:
if self.gpus_per_node is not None:
limits["nvidia.com/gpu"] = str(self.gpus_per_node)
requests["nvidia.com/gpu"] = str(self.gpus_per_node)
requests.update(self.extra_resource_requests)
limits.update(self.extra_resource_limits)
resources: dict[str, Any] = {}
if limits:
resources["limits"] = limits
Expand Down
Loading