fix(studio): Flashing on chat components when Code Agents is thinking#459
Merged
htolentino-nvidia merged 1 commit intoJun 25, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughClaude Code chat thread props are extracted into shared constants. The provider and runtime use memoized error/run callbacks and typed runtime handlers. The assistant run flow now delays message creation until after pre-run checks and no longer finalizes cancelled runs. ChangesClaude Code chat route updates
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
Hoisting MESSAGE_CONTENT_PROPS and EMPTY_STATE to module-level constants in ClaudeCodeChatThread prevents new object references on every render. This stabilises the messageComponents map passed to ThreadPrimitive.Messages so existing messages (code blocks, tables) no longer unmount/remount on each streaming chunk. Also extracts handleRun into a stable useCallback in useClaudeCodeChatRuntime and memoises onError in ClaudeCodeChatProvider, breaking the onRun → runCompletion → handleNewMessage → useExternalStoreRuntime cascade that previously caused the runtime to recreate on every chunk. Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1a59825 to
409a274
Compare
dmariali
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit