Skip to content

Move from zlib to zlib-ng optimized fork#3570

Merged
JanuszL merged 3 commits intoNVIDIA:mainfrom
JanuszL:move_zlib_ng
Jan 11, 2022
Merged

Move from zlib to zlib-ng optimized fork#3570
JanuszL merged 3 commits intoNVIDIA:mainfrom
JanuszL:move_zlib_ng

Conversation

@JanuszL
Copy link
Copy Markdown
Contributor

@JanuszL JanuszL commented Dec 14, 2021 •
edited
Loading

  • as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

  • moves from zlib to zlib-ng optimized fork
  • as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Additional information

  • Affected modules and functionalities:
    • deps
    • exclude lib list
  • Key points relevant for the review:
    • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 14, 2021

CI MESSAGE: [3593134]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3593134]: BUILD FAILED

@JanuszL JanuszL mentioned this pull request Dec 15, 2021
Merged
@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3593134]: BUILD PASSED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3598094]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3598155]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3598869]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3598869]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3598155]: BUILD PASSED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3599548]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 15, 2021

CI MESSAGE: [3599548]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 16, 2021

CI MESSAGE: [3605131]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 16, 2021

CI MESSAGE: [3605131]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 16, 2021

CI MESSAGE: [3607325]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 16, 2021

CI MESSAGE: [3607325]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3607325]: BUILD PASSED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3612167]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3612294]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3612294]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3613402]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3613402]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3613667]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3612167]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 17, 2021

CI MESSAGE: [3613667]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Dec 18, 2021

CI MESSAGE: [3612167]: BUILD PASSED

@JanuszL
Move from zlib to zlib-ng optimized fork
109e194 
- adds /lib64 to the LD_LIBRARY_PATH in the builder to
  make sure it can use system libs during the build

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Fix
951dd3b 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Update DEPS version
eeac736 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 10, 2022

CI MESSAGE: [3727692]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 10, 2022

CI MESSAGE: [3727692]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 10, 2022

CI MESSAGE: [3728946]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 10, 2022

CI MESSAGE: [3728946]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 11, 2022

CI MESSAGE: [3728946]: BUILD PASSED

@JanuszL JanuszL merged commit cc26158 into NVIDIA:main Jan 11, 2022
@JanuszL JanuszL deleted the move_zlib_ng branch January 11, 2022 09:53
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
9fea603 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
6aa8cc9 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
87c629d 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
9494b25 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
6b64b0c 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
1da1963 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
32c25a8 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
b05edbc 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
7c901d2 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
1245a34 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
5760e4a 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
b441510 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
2d8563e 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL added a commit to JanuszL/DALI that referenced this pull request Feb 16, 2022
@JanuszL
Revert "Move from zlib to zlib-ng optimized fork (NVIDIA#3570)"
49e267e 
This reverts commit cc26158.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
7ddb518 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
83e1aef 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@JanuszL @cyyever
Move from zlib to zlib-ng optimized fork (NVIDIA#3570)
26ef864 
- as zlib is linked statically this PR adds libz.a to list of excluded libs to avoid symbol overlap with system zlib

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klecki klecki klecki approved these changes

@stiepan stiepan stiepan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JanuszL @dali-automaton @klecki @stiepan