Skip to content

Add an upper bound for the video decoder workaround#3609

Merged
JanuszL merged 2 commits intoNVIDIA:mainfrom
JanuszL:uper_bound_vide_fix
Jan 11, 2022
Merged

Add an upper bound for the video decoder workaround#3609
JanuszL merged 2 commits intoNVIDIA:mainfrom
JanuszL:uper_bound_vide_fix

Conversation

@JanuszL
Copy link
Copy Markdown
Contributor

@JanuszL JanuszL commented Jan 10, 2022

  • there is a bug when decoding video on non-default stream
    in selected driver leading to memory corruption. This
    PR adds a check for the last driver version that needs
    the workaround

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

  • there is a bug when decoding video on non-default stream
    in selected driver leading to memory corruption. This
    PR adds a check for the last driver version that needs
    the workaround

Additional information

  • Affected modules and functionalities:
    • video loader
  • Key points relevant for the review:
    • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2534

@JanuszL
Add an upper bound for the video decoder workaround
105af84 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Copy Markdown
Contributor Author

JanuszL commented Jan 10, 2022

!build

@mzient mzient assigned mzient and unassigned banasraf Jan 11, 2022
mzient
mzient reviewed Jan 11, 2022
View reviewed changes
Comment thread dali/operators/reader/nvdecoder/nvdecoder.cc Outdated
nvml::Init();
static float driver_version = nvml::GetDriverVersion();
if (driver_version > 460)
if (driver_version > 460 && driver_version <= 470.21)
Copy link
Copy Markdown
Contributor

@mzient mzient Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (driver_version > 460 && driver_version <= 470.21)
if (driver_version > 460 && driver_version < 470.21)

I think it was fixed in 470.21 or even earlier.

Copy link
Copy Markdown
Contributor Author

@JanuszL JanuszL Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JanuszL
Review fix
de215de 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Copy Markdown
Contributor Author

JanuszL commented Jan 11, 2022

!build

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 11, 2022

CI MESSAGE: [3734504]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Jan 11, 2022

CI MESSAGE: [3734504]: BUILD PASSED

@JanuszL JanuszL merged commit e1f563b into NVIDIA:main Jan 11, 2022
@JanuszL JanuszL deleted the uper_bound_vide_fix branch January 11, 2022 12:29
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
b685b20 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
7e9aa43 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
87c0ad4 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
e725822 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
4a0c9fc 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
2aa2176 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
7286a89 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
db09100 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
468e584 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
842cc83 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
c44c7fc 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
a7bab44 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
1d8cf94 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
739d89e 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@szalpal szalpal added the important-fix Fixes an important issue in the software or development environment. label Mar 1, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
33cf635 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@JanuszL @cyyever
Add an upper bound for the video decoder workaround (NVIDIA#3609)
bac5d67 
- there is a bug when decoding video on non-default stream
  in selected driver leading to memory corruption. This
  PR adds a check for the last driver version that needs
  the workaround

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@mzient mzient mzient approved these changes

Assignees

@jantonguirao jantonguirao

@mzient mzient

Labels

important-fix Fixes an important issue in the software or development environment.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JanuszL @dali-automaton @jantonguirao @mzient @szalpal @banasraf