Set rpath at cmake level (do not wait for bundle-wheel)#5323
Merged
jantonguirao merged 2 commits intoNVIDIA:mainfrom Feb 16, 2024
Merged
Set rpath at cmake level (do not wait for bundle-wheel)#5323jantonguirao merged 2 commits intoNVIDIA:mainfrom
jantonguirao merged 2 commits intoNVIDIA:mainfrom
Conversation
jantonguirao
force-pushed
the
rpath-nvimgcodec
branch
from
c93e1fb to
1454756
Compare
JanuszL
reviewed
Feb 15, 2024
| endif() | ||
|
|
||
|
|
||
| foreach(rpath IN ITEMS |
Contributor
There was a problem hiding this comment.
How it affects conda build?
Contributor
Author
There was a problem hiding this comment.
It shouldn't. Conda build doesn't care about those paths anyway, and resets the rpath completely
Contributor
There was a problem hiding this comment.
OK, we are overwriting them anyway https://github.com/NVIDIA/DALI/blob/main/conda/dali_native_libs/recipe/build.sh#L216.
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [12841037]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [12841037]: BUILD FAILED |
mzient
approved these changes
Feb 15, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
rpath-nvimgcodec
branch
from
1454756 to
f2ddd38
Compare
Collaborator
|
CI MESSAGE: [12842935]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Collaborator
|
CI MESSAGE: [12842935]: BUILD PASSED |
jantonguirao
commented
Feb 16, 2024
| nvimgcodec_headers | ||
| URL https://developer.download.nvidia.com/compute/nvimgcodec/redist/nvimgcodec/linux-x86_64/nvimgcodec-linux-x86_64-0.2.0.6-archive.tar.xz | ||
| URL_HASH SHA512=6577a8ff5589400cdf5767aa4a507245527a96e48065f23f626dfc6ba13b136960cacfe7f61c345dc158ed0352e1e971834aec6fd98038649b08b250c3306aeb | ||
| DOWNLOAD_EXTRACT_TIMESTAMP 1 |
Contributor
Author
There was a problem hiding this comment.
this is to silence a warning
szalpal
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Other
Description:
Improvement: Set rpath during build and not later during bundle-wheel. This allows for doing pip install directly from build directory without the need to build a wheel, and still be able to detect nvimgcodec installed in the python directory.
Additional information:
Affected modules and functionalities:
experimental decoders
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A