Disable more video tests on selected machines#5385
Merged
klecki merged 2 commits intoNVIDIA:mainfrom Mar 22, 2024
Merged
Conversation
Move the check to test_utils Disable tests that try to use codecs that are unsupported on M60. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
awolant
approved these changes
Mar 20, 2024
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [13686793]: BUILD STARTED |
mzient
reviewed
Mar 21, 2024
Comment on lines
+82
to
+87
| def skip_if_m60(): | ||
| """Skip the test if the GPU is M60. The video decoder is not supported in full on M60.""" | ||
|
|
||
| gpus = get_gpu_name_from_nvml() | ||
| if "Tesla M60" in gpus: | ||
| raise SkipTest() |
Contributor
There was a problem hiding this comment.
Can't we just restrict the entire family of GPUs with compute capability <6.0? AFAIK Tesla M60 is a Maxwell, so it must be 5.x. Are there any pre-6.0 machines on which the tests did work?
Contributor
Author
There was a problem hiding this comment.
That was the solution we decided last time, to do specific filtering for now, as what codecs on what GPUs are available is not straightforward and we want to run as many tests as possible.
Maybe @awolant can give you more details.
Contributor
There was a problem hiding this comment.
Meh. Approved, but I'm not comfortable with hardcoding things specific to our CI in our main source repo.
Collaborator
|
CI MESSAGE: [13686793]: BUILD PASSED |
mzient
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: Other
Description:
Move the check to test_utils
Disable tests that try to use codecs that are unsupported on M60.
Additional information:
Affected modules and functionalities:
Video tests
Key points relevant for the review:
Tests:
Some tests were disabled for Tesla M60
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A