Refactor to remove duplicated logic in traverse_directories utility function#5419
Merged
jantonguirao merged 3 commits intoNVIDIA:mainfrom Apr 11, 2024
Merged
Conversation
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
changed the title
jantonguirao
changed the title
mzient
reviewed
Apr 10, 2024
mzient
reviewed
Apr 10, 2024
mzient
reviewed
Apr 10, 2024
mzient
reviewed
Apr 10, 2024
mzient
reviewed
Apr 10, 2024
mzient
reviewed
Apr 10, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
mzient
reviewed
Apr 10, 2024
mzient
approved these changes
Apr 10, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
traverse_directories_refactor
branch
from
c6ea4c1 to
501aa17
Compare
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [14130197]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [14130197]: BUILD PASSED |
banasraf
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring
Description:
Refactors to avoid duplicated code in traverse_directories implementation
Additional information:
Affected modules and functionalities:
FileReader, NumpyReader, FitsReader...
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A