Merged
Conversation
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
JanuszL
approved these changes
May 9, 2024
Collaborator
|
CI MESSAGE: [14875991]: BUILD STARTED |
jantonguirao
approved these changes
May 9, 2024
Collaborator
|
CI MESSAGE: [14875991]: BUILD FAILED |
Contributor
Author
The relevant job passed; failed on jax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
We build DALI with C++17, but a test target used the compiler's default (which happened to be c++14). This PR explicitly sets the standard in the test target.
Additional information:
Affected modules and functionalities:
Nodeps test.
Key points relevant for the review:
Tests:
qa/TL1_nodeps_build
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A