Skip to content

Use C++17 standard in nodeps test.#5459

Merged
mzient merged 1 commit intoNVIDIA:mainfrom
mzient:fix_nodeps_build
May 9, 2024
Merged

Use C++17 standard in nodeps test.#5459
mzient merged 1 commit intoNVIDIA:mainfrom
mzient:fix_nodeps_build

Conversation

@mzient
Copy link
Contributor

@mzient mzient commented May 9, 2024

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

We build DALI with C++17, but a test target used the compiler's default (which happened to be c++14). This PR explicitly sets the standard in the test target.

Additional information:

Affected modules and functionalities:

Nodeps test.

Key points relevant for the review:

Tests:

qa/TL1_nodeps_build

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@JanuszL JanuszL self-assigned this May 9, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14875991]: BUILD STARTED

@jantonguirao jantonguirao assigned jantonguirao and unassigned klecki May 9, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14875991]: BUILD FAILED

@mzient
Copy link
Contributor Author

mzient commented May 9, 2024

CI MESSAGE: [14875991]: BUILD FAILEDSphinx: [14875991]: BUILD FAILEDDoxygen: [14875991]: BUILD FAILED

The relevant job passed; failed on jax.

@mzient mzient merged commit fb1d9da into NVIDIA:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants