Add python function operator - DALI-571 by banasraf · Pull Request #732 · NVIDIA/DALI

banasraf · 2019-04-02T15:39:04Z

Added python operator, a test and a jupyter notebook.

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

dali/pipeline/operators/python_function/python_function.h

docs/examples/color_space_conversion.ipynb

docs/examples/getting started.ipynb

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

dali/pipeline/operators/python_function/python_function.cc

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

JanuszL · 2019-04-02T17:07:42Z

dali/pipeline/operators/python_function/python_function.cc

+  const auto &input = ws->Input<CPUBackend>(idx);
+  auto &output = ws->Output<CPUBackend>(idx);
+  py::gil_scoped_acquire guard{};
+  py::array output_array = python_function(tensorToNumpyArray(input));


Maybe we can provide instead of one NumpyArray a list of based on the number of inputs provided to the operator?

JanuszL · 2019-04-02T17:08:23Z

dali/pipeline/operators/python_function/python_function.cc

+  const auto &input = ws->Input<CPUBackend>(idx);
+  auto &output = ws->Output<CPUBackend>(idx);
+  py::gil_scoped_acquire guard{};
+  py::array output_array = python_function(tensorToNumpyArray(input));


And maybe we could accept list on NumpyArrays to get multiple outputs from the operator?

JanuszL · 2019-04-02T17:10:09Z

dali/pipeline/operators/python_function/python_function.cc

+  const auto &input = ws->Input<CPUBackend>(idx);
+  auto &output = ws->Output<CPUBackend>(idx);
+  py::gil_scoped_acquire guard{};
+  py::array output_array = python_function(tensorToNumpyArray(input));


What is the lifetime of this output_array? Maybe we can share its memory with the tensor and took over the ownership instead of copying it?

dali/pipeline/operators/python_function/CMakeLists.txt

dali/pipeline/operators/python_function/python_function.cc

dali/test/python/test_python_function_operator.py

dali/CMakeLists.txt

dali/pipeline/operators/python_function/python_function.cc

jantonguirao · 2019-04-03T09:01:24Z

dali/python/backend_impl.cc

          p->SetOutputNames(outputs);
          })
-    .def("RunCPU", &Pipeline::RunCPU)
+    .def("RunCPU", &Pipeline::RunCPU, py::call_guard<py::gil_scoped_release>())


I am just wondering what is this extra argument doing. Any performance implications (since this affects any pipeline's RunCPU)

What it does is releasing the python global interpreter lock. Since a normal pipeline execution does not touch any python's resources it is safe to do it while not holding the GIL. Speaking about performance, actually it could even help because it unlocks the interpreter for other python threads. Of course in case of a python operator, GIL must be reacquired before executing.

dali/test/python/test_python_function_operator.py

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki

CI MESSAGE: [705291]: BUILD STARTED

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki

CI MESSAGE: [705327]: BUILD STARTED

klecki

CI MESSAGE: [705327]: BUILD PASSED

dali/python/nvidia/dali/ops.py

dali/python/nvidia/dali/backend.py

dali/python/nvidia/dali/ops.py

dali/python_function/python_function.cc

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki

CI MESSAGE: [706273]: BUILD STARTED

klecki

CI MESSAGE: [706273]: BUILD FAILED

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki

CI MESSAGE: [706487]: BUILD FAILED

klecki

CI MESSAGE: [706491]: BUILD FAILED

klecki

CI MESSAGE: [706494]: BUILD STARTED

klecki

CI MESSAGE: [706494]: BUILD PASSED

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki

CI MESSAGE: [706568]: BUILD STARTED

dali/python/nvidia/dali/ops.py

klecki

CI MESSAGE: [706568]: BUILD PASSED

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki · 2019-04-17T09:55:41Z

CI MESSAGE: [707545]: BUILD STARTED

klecki · 2019-04-17T11:51:33Z

CI MESSAGE: [707545]: BUILD PASSED

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

* Add python function operator. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add custom python operator example. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add custom python operator example. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix style Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix style. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix test to follow nosetest convention Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add test to the test script Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix docker build. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move python operator to external plugin Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add proper documentation for the operator Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move plugin loading to backend.py Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix example notebook Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move plugin loading to the operator constructor. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move plugin loading to backend initialization. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move the operator to pipeline/operators Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix registring python wrapper ops Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Typo fix Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> Signed-off-by: kychennv <kychen@nvidia.com>

* Add python function operator. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add custom python operator example. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add custom python operator example. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix style Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix style. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix test to follow nosetest convention Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add test to the test script Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix docker build. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move python operator to external plugin Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Add proper documentation for the operator Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move plugin loading to backend.py Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix example notebook Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move plugin loading to the operator constructor. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move plugin loading to backend initialization. Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Move the operator to pipeline/operators Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Fix registring python wrapper ops Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com> * Typo fix Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

Rafał Banaś added 2 commits April 2, 2019 17:35

Add python function operator.

7d5bcae

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

Add custom python operator example.

9fe51fb

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

banasraf requested review from JanuszL, Kh4L, awolant, jantonguirao, klecki and mzient April 2, 2019 15:39

jantonguirao reviewed Apr 2, 2019

View reviewed changes

dali/pipeline/operators/python_function/python_function.h Outdated Show resolved Hide resolved

jantonguirao reviewed Apr 2, 2019

View reviewed changes

docs/examples/color_space_conversion.ipynb Show resolved Hide resolved

jantonguirao reviewed Apr 2, 2019

View reviewed changes

docs/examples/getting started.ipynb Outdated Show resolved Hide resolved

Add custom python operator example.

acab643

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

Kh4L reviewed Apr 2, 2019

View reviewed changes

dali/pipeline/operators/python_function/python_function.cc Outdated Show resolved Hide resolved

Remove unneeded changes in notebooks.

48daf56

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

JanuszL mentioned this pull request Apr 2, 2019

Labels for video files with ops.VideoReader #666

Closed

Fix style

607e75b

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

JanuszL reviewed Apr 2, 2019

View reviewed changes

mzient reviewed Apr 3, 2019

View reviewed changes

dali/pipeline/operators/python_function/CMakeLists.txt Outdated Show resolved Hide resolved

mzient reviewed Apr 3, 2019

View reviewed changes

dali/pipeline/operators/python_function/python_function.cc Outdated Show resolved Hide resolved

mzient reviewed Apr 3, 2019

View reviewed changes

dali/pipeline/operators/python_function/python_function.cc Outdated Show resolved Hide resolved

mzient reviewed Apr 3, 2019

View reviewed changes

dali/pipeline/operators/python_function/python_function.cc Outdated Show resolved Hide resolved

mzient reviewed Apr 3, 2019

View reviewed changes

dali/test/python/test_python_function_operator.py Outdated Show resolved Hide resolved

jantonguirao reviewed Apr 3, 2019

View reviewed changes

Rafał Banaś added 2 commits April 4, 2019 13:47

Fix style.

1c13757

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

Fix test to follow nosetest convention

49eae64

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

banasraf force-pushed the add_python_function_operator branch from 712b2bc to 49eae64 Compare April 8, 2019 08:50

Rafał Banaś added 2 commits April 8, 2019 13:28

Merge master

381eeff

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

Add test to the test script

e563af2

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki reviewed Apr 15, 2019

View reviewed changes

Fix example notebook

4d04c8b

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki reviewed Apr 15, 2019

View reviewed changes

mzient reviewed Apr 16, 2019

View reviewed changes

dali/python/nvidia/dali/ops.py Show resolved Hide resolved

Kh4L reviewed Apr 16, 2019

View reviewed changes

dali/python/nvidia/dali/backend.py Outdated Show resolved Hide resolved

dali/python/nvidia/dali/ops.py Show resolved Hide resolved

dali/python_function/python_function.cc Outdated Show resolved Hide resolved

Move plugin loading to the operator constructor.

e192215

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki reviewed Apr 16, 2019

View reviewed changes

Move plugin loading to backend initialization.

82cdaed

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki reviewed Apr 16, 2019

View reviewed changes

Move the operator to pipeline/operators

fee814c

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

klecki reviewed Apr 16, 2019

View reviewed changes

jantonguirao reviewed Apr 16, 2019

View reviewed changes

dali/python/nvidia/dali/ops.py Outdated Show resolved Hide resolved

klecki reviewed Apr 16, 2019

View reviewed changes

Fix registring python wrapper ops

3e31a09

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

JanuszL approved these changes Apr 17, 2019

View reviewed changes

banasraf requested a review from szalpal April 18, 2019 09:08

Kh4L approved these changes Apr 21, 2019

View reviewed changes

szalpal approved these changes Apr 30, 2019

View reviewed changes

Typo fix

ad5e237

Signed-off-by: Rafał Banaś <Banas.Rafal97@gmail.com>

JanuszL merged commit 398ced8 into NVIDIA:master Apr 30, 2019

JanuszL mentioned this pull request May 8, 2019

Example snippets and support for python custom operator #296

Closed

Conversation

banasraf commented Apr 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanuszL Apr 2, 2019

Choose a reason for hiding this comment

Uh oh!

JanuszL Apr 2, 2019

Choose a reason for hiding this comment

Uh oh!

JanuszL Apr 2, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jantonguirao Apr 3, 2019

Choose a reason for hiding this comment

Uh oh!

banasraf Apr 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

klecki left a comment

Choose a reason for hiding this comment

Uh oh!

klecki commented Apr 17, 2019

Uh oh!

klecki commented Apr 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects