Skip to content

Improve error message when unable to set CPU affinity #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jantonguirao merged 3 commits into from
Apr 18, 2019
Merged

Improve error message when unable to set CPU affinity #775

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c2d15d
[WIP][TEST] Print failure about set affinity failure
jantonguirao Apr 12, 2019
f040400
[temp] More debugging info
jantonguirao Apr 15, 2019
a499081
Add clearer warning message when CPU affinity doesn't requirements
jantonguirao Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dali/util/nvml.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,17 @@ inline void SetCPUAffinity(int core = -1) {
}

// Set the affinity
bool at_least_one_cpu_set = false;
for (std::size_t i = 0; i < num_cpus; i++) {
at_least_one_cpu_set |= CPU_ISSET(i, &requested_set);
}
if (!at_least_one_cpu_set) {
DALI_WARN("CPU affinity requested by user or recommended by nvml setting"
" does not meet allowed affinity for given DALI thread."
" Use taskset tool to check allowed affinity");
return;
}

int error = pthread_setaffinity_np(pthread_self(), sizeof(requested_set), &requested_set);
if (error != 0) {
DALI_WARN("Setting affinity failed! Error code: " + to_string(error));
Expand Down