Conversation
CMake 3.11 was released on March 28th, 2018. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [717822]: BUILD STARTED |
|
CI MESSAGE: [717822]: BUILD FAILED |
|
CI MESSAGE: [717828]: BUILD STARTED |
| # limitations under the License. | ||
|
|
||
| cmake_minimum_required(VERSION 3.5) | ||
| cmake_minimum_required(VERSION 3.11) |
There was a problem hiding this comment.
any reason behind this?
There was a problem hiding this comment.
We have some workarounds for older CMakes, that could be cleaned up along the way, and I want to use newer FindCuda that has better support for cross-compiling.
|
CI MESSAGE: [717828]: BUILD FAILED |
|
Please update the readme requirements for DALI build, add information how to update CMake to given version and we can remove FindProtobuf.cmake. |
Will do, but I intend to leave FindProtobuf.cmake for now, as it does not understand cross-compilation AFAIK. |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [717828]: BUILD PASSED |
|
CI MESSAGE: [719793]: BUILD STARTED |
|
CI MESSAGE: [719793]: BUILD PASSED |
CMake 3.11 was released on March 28th, 2018. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com> Signed-off-by: kychennv <kychen@nvidia.com>
CMake 3.11 was released on March 28th, 2018. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
5 participants
CMake 3.11 was released on March 28th, 2018.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com