Fix unnecesary memory usage when reallocating#847
Merged
mzient merged 2 commits intoNVIDIA:masterfrom May 6, 2019
Merged
Conversation
JanuszL
approved these changes
May 6, 2019
jantonguirao
approved these changes
May 6, 2019
klecki
approved these changes
May 6, 2019
…allocatedScratchpad`. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
force-pushed
the
ScratchAllocNoDoubleMem
branch
from
8f2617a to
fb1ed19
Compare
Contributor
Author
|
!build |
JanuszL
changed the title
JanuszL
approved these changes
May 6, 2019
Collaborator
|
CI MESSAGE: [726586]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [726588]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [726586]: BUILD FAILED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
force-pushed
the
ScratchAllocNoDoubleMem
branch
from
9450b71 to
8c5c939
Compare
JanuszL
approved these changes
May 6, 2019
Collaborator
|
CI MESSAGE: [726685]: BUILD STARTED |
jantonguirao
approved these changes
May 6, 2019
Collaborator
|
CI MESSAGE: [726685]: BUILD PASSED |
kychennv
pushed a commit
to kychennv/DALI
that referenced
this pull request
May 14, 2019
* Free memory before allocating new, larger buffer in `Buffer` and `PreallocatedScratchpad`. * Fix tests explicitly expecting pointer change. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com> Signed-off-by: kychennv <kychen@nvidia.com>
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
* Free memory before allocating new, larger buffer in `Buffer` and `PreallocatedScratchpad`. * Fix tests explicitly expecting pointer change. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't assume that buffer contents are maintained accross allocation - as such, we can free the memory before attempting to allocate a new buffer.
Signed-off-by: Michal Zientkiewicz michalz@nvidia.com