Fix CropMirrorNormalize crop_pos_x/y argument for the CPU#853
Fix CropMirrorNormalize crop_pos_x/y argument for the CPU#853JanuszL merged 1 commit intoNVIDIA:masterfrom JanuszL:fix_cpu_cmn
Conversation
|
CI MESSAGE: [727946]: BUILD STARTED |
|
CI MESSAGE: [727946]: BUILD FAILED |
There was a problem hiding this comment.
The distribution is skewed. Should be:
| int crop_y = crop_y_image_coord * (H - crop_h_); | |
| int crop_y = std::floor(crop_y_image_coord * (H - crop_h_) + 0.5f); |
There was a problem hiding this comment.
Will do (for GPU and crop itself as well).
There was a problem hiding this comment.
| int crop_x = crop_x_image_coord * (W - crop_w_); | |
| int crop_x = std::floor(crop_x_image_coord * (W - crop_w_) + 0.5f); |
There was a problem hiding this comment.
Will do (for GPU and crop itself as well).
|
CI MESSAGE: [729062]: BUILD STARTED |
|
CI MESSAGE: [729062]: BUILD FAILED |
|
CI MESSAGE: [729130]: BUILD STARTED |
|
CI MESSAGE: [729130]: BUILD PASSED |
dali/test/dali_test_resize.h
Outdated
There was a problem hiding this comment.
https://en.cppreference.com/w/cpp/numeric/math/round
| const int crop_y = std::floor(0.5f * (rsz_h - crop_h) + 0.5f); | |
| const int crop_y = std::round(0.5f * (rsz_h - crop_h)); |
same applies to other occurrences
|
CI MESSAGE: [730546]: BUILD STARTED |
|
CI MESSAGE: [730546]: BUILD FAILED |
|
CI MESSAGE: [730648]: BUILD STARTED |
|
CI MESSAGE: [730648]: BUILD FAILED |
- makes CropMirrorNormalize take into account crop_pos_x and crop_pos_y arguments Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [730775]: BUILD STARTED |
|
CI MESSAGE: [730775]: BUILD PASSED |
- makes CropMirrorNormalize take into account crop_pos_x and crop_pos_y arguments Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> Signed-off-by: kychennv <kychen@nvidia.com>
- makes CropMirrorNormalize take into account crop_pos_x and crop_pos_y arguments Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
4 participants
crop_pos_y arguments
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com