This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Change file concat to os path join#1004
Merged
lukeyeager merged 1 commit intoNVIDIA:masterfrom Aug 26, 2016
Merged
Conversation
| Get path to model definition | ||
| """ | ||
| return self.job_dir+"/original.prototxt" | ||
| return os.path.join(self.job_dir,"original.prototxt") |
Contributor
There was a problem hiding this comment.
it's maybe just me but I like to see a space after commas in argument lists...
Contributor
Author
There was a problem hiding this comment.
@gheinrich That sounds reasonable! I added them in my last commit :)
Lucaszw
force-pushed
the
change_file_concat_to_os_path_join
branch
from
19949bb to
e3d3f3b
Compare
Lucaszw
force-pushed
the
change_file_concat_to_os_path_join
branch
from
e3d3f3b to
d6703e8
Compare
Member
|
Again, Travis failures are unrelated. |
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
…path_join Change file concat to os path join
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change file concat to os path join