Set autoincrementing index in FusionExecutor::compileRtc#1162
Draft
jacobhinkle wants to merge 5 commits intomainfrom
Draft
Set autoincrementing index in FusionExecutor::compileRtc#1162jacobhinkle wants to merge 5 commits intomainfrom
jacobhinkle wants to merge 5 commits intomainfrom
Conversation
compileRtc is used only in a few tests (seven currently) to test basic
compilation functionality. Currently, calling compileRtc does not use
fusion_id_counter_, and does not set fusion_id_ until after calling
getStructuredCode. This means that if we print the kernel or compiled
PTX, we get a file named like `__tmp_kernel-1.{cu,ptx}`. Here -1 is the
default value of `fusion_id_`. This has caused a problem in codegen
diff, which expects us to not overwrite these files, and for them to
follow a somewhat regular naming scheme.
This change simply sets the ID before `getStructuredCode` using
`fusion_id_counter_` to mimic what happens in `compileFusion`.
Collaborator
Author
|
!build |
Collaborator
Author
|
!build --diff |
Collaborator
Author
|
!build --diff |
Collaborator
Author
|
!build --diff |
jacobhinkle
requested review from
rdspring1 and
xwang233
and removed request for
xwang233
Collaborator
Author
|
With the latest change in #1330 we no longer have stuff like |
Collaborator
|
@jacobhinkle Is this still relevant? |
Collaborator
Author
It is not. I need to do some spring cleaning on all of my old draft PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compileRtc is used only in a few tests (seven currently) to test basic compilation functionality. Currently, calling compileRtc does not use fusion_id_counter_, and does not set fusion_id_ until after calling getStructuredCode. This means that if we print the kernel or compiled PTX, we get a file named like
__tmp_kernel-1.{cu,ptx}. Here -1 is the default value offusion_id_. This has caused a problem in codegen diff, which expects us to not overwrite these files, and for them to follow a somewhat regular naming scheme.This change simply sets the ID before
getStructuredCodeusingfusion_id_counter_to mimic what happens incompileFusion.