Skip to content

Comments

[DO NOT MERGE] Test mypy linting#4838

Draft
jacobhinkle wants to merge 2 commits intomypy_configfrom
jh/test_mypy_config
Draft

[DO NOT MERGE] Test mypy linting#4838
jacobhinkle wants to merge 2 commits intomypy_configfrom
jh/test_mypy_config

Conversation

@jacobhinkle
Copy link
Collaborator

This just tests the CI job in #1077

@jacobhinkle jacobhinkle changed the base branch from main to mypy_config July 24, 2025 11:53
@github-actions
Copy link

github-actions bot commented Jul 24, 2025

Review updated until commit 6345c32

Description

  • Fix typo in function name etry_on_oom_or_skip_test

  • Add newline in benchmark_utils.py for formatting


Changes walkthrough 📝

Relevant files
Formatting
benchmark_utils.py
Add newline for formatting                                                             

python/nvfuser/benchmark_utils.py

  • Added newline for formatting
+1/-0     
Bug fix
pytorch_utils.py
Fix function name typo                                                                     

python/nvfuser/pytorch_utils.py

  • Corrected function name typo from etry_on_oom_or_skip_test to
    retry_on_oom_or_skip_test
  • +1/-1     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Typo

    The function name etry_on_oom_or_skip_test seems to be a typo. It should be retry_on_oom_or_skip_test.

    def etry_on_oom_or_skip_test(func):

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant