Skip to content

ROS: Publish raw controller commands in teleop mode#393

Merged
sgrizan-nv merged 1 commit intomainfrom
sgrizan/branch2
Apr 14, 2026
Merged

ROS: Publish raw controller commands in teleop mode#393
sgrizan-nv merged 1 commit intomainfrom
sgrizan/branch2

Conversation

@sgrizan-nv
Copy link
Copy Markdown
Collaborator

@sgrizan-nv sgrizan-nv commented Apr 14, 2026

Summary by CodeRabbit

  • New Features
    • Extended controller data transmission to support the "controller_teleop" mode in addition to existing operational modes, enabling controller input to be published in more scenarios for enhanced teleoperation capabilities.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 86081fe7-e040-4a69-b8da-59d18ff3f5a6

📥 Commits

Reviewing files that changed from the base of the PR and between 6dc83ab and f45d8a8.

📒 Files selected for processing (1)
  • examples/teleop_ros2/python/teleop_ros2_node.py

📝 Walkthrough

Walkthrough

A single condition in the teleop ROS2 node has been modified to expand the set of modes that trigger publication of controller data to include "controller_teleop" alongside existing modes "controller_raw" and "full_body". The actual publishing logic, payload construction, and control flow remain unchanged; only the condition determining eligibility for publication has been broadened.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: expanding controller data publication to include the 'controller_teleop' mode, which aligns with publishing raw controller commands in teleop mode.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgrizan/branch2

Comment @coderabbitai help to get the list of available commands and usage tips.

@sgrizan-nv sgrizan-nv linked an issue Apr 14, 2026 that may be closed by this pull request
@sgrizan-nv sgrizan-nv enabled auto-merge (squash) April 14, 2026 17:52
@sgrizan-nv sgrizan-nv merged commit 9d24cd1 into main Apr 14, 2026
39 checks passed
@sgrizan-nv sgrizan-nv deleted the sgrizan/branch2 branch April 14, 2026 18:11
@github-project-automation github-project-automation Bot moved this from TODO to DONE in Isaac Teleop Planning Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: DONE

Development

Successfully merging this pull request may close these issues.

ROS: Publish raw controller commands in teleop mode

2 participants