Skip to content

Port web client perf updates from cloudxr-js 6.2.0#530

Merged
yanziz-nvidia merged 1 commit into
mainfrom
yanziz/cxr-js-client-update
May 21, 2026
Merged

Port web client perf updates from cloudxr-js 6.2.0#530
yanziz-nvidia merged 1 commit into
mainfrom
yanziz/cxr-js-client-update

Conversation

@yanziz-nvidia
Copy link
Copy Markdown
Contributor

@yanziz-nvidia yanziz-nvidia commented May 14, 2026

depends on #528

  • Port the canvas-backed performance metrics panel from the upstream cloudxr-js sample: replace the per-frame uikit Container/Text tree in CloudXRUI.tsx with a single PerformanceCanvasImage to avoid uikit layout recalcs every frame while the panel is open in XR.
  • Updates shared dependency
  • Bumps telemetry to 6.2.0 to match 6.2.0 SDK target

Test plan

  • npm install && npm run build succeeds in deps/cloudxr/webxr_client/.
  • CI Build CloudXR Web Client action resolves 6.2.0-rc4 from private NGC.
  • Launch a WebXR session, open the in-XR control panel, confirm the Render FPS / Streaming FPS / Pose-to-Render values update each frame and look correct.
  • Toggle Headless from the 2D UI and confirm the per-frame WebGL path remains skipped.
  • Sanity-check non-XR pages render with the new three/r3f versions.

Summary by CodeRabbit

  • New Features

    • Added a visual performance metrics panel displaying render FPS, streaming FPS, and pose-to-render metrics in real-time.
  • Chores

    • Version updated to 6.2.0.
    • Updated runtime and development dependencies.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c67718e6-dfa5-4c59-8cc8-313d5046a817

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: updating the web client performance metrics from cloudxr-js 6.2.0, including new PerformanceCanvasImage component, version bump from 6.1.0 to 6.2.0, and dependency updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yanziz/cxr-js-client-update

Comment @coderabbitai help to get the list of available commands and usage tips.

@yanziz-nvidia
Copy link
Copy Markdown
Contributor Author

/preview-docs

@yanziz-nvidia yanziz-nvidia force-pushed the yanziz/cxr-js-client-update branch from c9fc8f0 to bedbae5 Compare May 15, 2026 16:49
Base automatically changed from yanziz/cxr-js-620 to main May 21, 2026 05:21
@yanziz-nvidia yanziz-nvidia force-pushed the yanziz/cxr-js-client-update branch from bedbae5 to 4e4fec8 Compare May 21, 2026 17:07
Switch the in-XR Performance panel from a per-frame uikit Container/Text
tree to a single canvas-backed Image (PerformanceCanvasImage) to avoid
uikit layout recalculations every frame while the panel is visible.
Bump shared deps to match the upstream rc4 sample for security and to
keep the @react-three/* and three.js versions in lockstep with the SDK.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@yanziz-nvidia yanziz-nvidia force-pushed the yanziz/cxr-js-client-update branch from 4e4fec8 to 142cbc5 Compare May 21, 2026 18:39
@yanziz-nvidia yanziz-nvidia merged commit e0d8250 into main May 21, 2026
48 checks passed
@yanziz-nvidia yanziz-nvidia deleted the yanziz/cxr-js-client-update branch May 21, 2026 20:52
yanziz-nvidia added a commit that referenced this pull request May 21, 2026
* Revert "Port web client perf updates from cloudxr-js 6.2.0 (#530)"

This reverts commit e0d8250.

* Revert "deps: bump @nvidia/cloudxr to 6.2.0 (#528)"

This reverts commit 8b57406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants