fix: remove sdr_as_percent kwarg from compute_syndrome_density() call#30
Merged
Merged
Conversation
compute_syndrome_density() does not accept sdr_as_percent — the flag is only used downstream in train.py for display formatting (the SDR unit shown as "%" vs "x"). Passing it caused a TypeError that aborted the orientation-inference long-running CI job after a full training epoch. Fixes: TypeError: compute_syndrome_density() got an unexpected keyword argument 'sdr_as_percent' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ivan Basov <ibasov@nvidia.com>
ivanbasov
added a commit
that referenced
this pull request
Apr 10, 2026
…#30) compute_syndrome_density() does not accept sdr_as_percent — the flag is only used downstream in train.py for display formatting (the SDR unit shown as "%" vs "x"). Passing it caused a TypeError that aborted the orientation-inference long-running CI job after a full training epoch. Fixes: TypeError: compute_syndrome_density() got an unexpected keyword argument 'sdr_as_percent' Signed-off-by: Ivan Basov <ibasov@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
ivanbasov
added a commit
that referenced
this pull request
Apr 10, 2026
…#30) compute_syndrome_density() does not accept sdr_as_percent — the flag is only used downstream in train.py for display formatting (the SDR unit shown as "%" vs "x"). Passing it caused a TypeError that aborted the orientation-inference long-running CI job after a full training epoch. Fixes: TypeError: compute_syndrome_density() got an unexpected keyword argument 'sdr_as_percent' Signed-off-by: Ivan Basov <ibasov@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
orientation-inferencelong-running CI job (run 23522886720) failed after a full training epoch with:Root cause
train.pypassessdr_as_percent=sdr_as_percenttocompute_syndrome_density(), but that function's signature is:sdr_as_percentis only used after the call returns, for display formatting of the SDR unit ("%" vs "x"). It has no role insidecompute_syndrome_density().Fix
Remove the stray
sdr_as_percent=sdr_as_percentkeyword argument from the call site intrain.py(one line deleted).Test plan
orientation-inferenceCI job passes🤖 Generated with Claude Code