Skip to content

ci: exempt images and notebooks from 100 KB file-size gate#64

Merged
ivanbasov merged 2 commits into
mainfrom
fix/pr-file-check-notebook-exemption
Apr 10, 2026
Merged

ci: exempt images and notebooks from 100 KB file-size gate#64
ivanbasov merged 2 commits into
mainfrom
fix/pr-file-check-notebook-exemption

Conversation

@ivanbasov
Copy link
Copy Markdown
Collaborator

Summary

The pr_file_check.yaml 100 KB gate blocks documentation assets that are legitimate large files:

  • Image formats (PNG/JPG/GIF/SVG/ICO/WebP) — figures for notebooks and docs
  • Jupyter notebooks (.ipynb) — can embed base64-encoded images for self-contained rendering on GitHub

This PR exempts both categories from the size check. Code and data files (the actual targets of the gate) remain subject to the limit.

Needed to unblock #63 (tutorial notebook with embedded images).

🤖 Generated with Claude Code

Documentation assets (PNG/JPG/GIF/SVG/ICO/WebP) and Jupyter notebooks
(.ipynb) are legitimate large files that should not be blocked by the
binary-size check. Notebooks can embed base64-encoded images to ensure
self-contained rendering on GitHub.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ivanbasov ivanbasov requested a review from bmhowe23 April 10, 2026 21:37
Documentation assets (PNG/JPG/GIF/SVG/ICO/WebP) and Jupyter notebooks
(.ipynb) are legitimate large files that should not be blocked by the
binary-size check. Notebooks can embed base64-encoded images to ensure
self-contained rendering on GitHub.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I begrudgingly approve 😬

@ivanbasov ivanbasov merged commit 9668dd3 into main Apr 10, 2026
17 checks passed
@ivanbasov ivanbasov mentioned this pull request Apr 10, 2026
2 tasks
@bmhowe23 bmhowe23 deleted the fix/pr-file-check-notebook-exemption branch April 13, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants