Do not emit arch-conditional PTX #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouiz
previously approved these changes
Feb 13, 2025
Collaborator
nouiz
left a comment
nouiz
left a comment
There was a problem hiding this comment.
Maybe update the description that this also drop arch before and including V100 that we don't support anymore with this container?
Arch-conditional PTX cannot be JIT compiled to newer architectures. These lists are only applies to a few kernels built into JAX/XLA, so emitting arch-conditional code should not be important. Also, remove deprecated support for pre-Turing architectures.
olupton
force-pushed
the
olupton/tune-build-arch
branch
from
26a18d6 to
a7932cb
Compare
Collaborator
|
Looks good, but it looks like I do not have permissions to approve. Update: Scratch that, I have the permissions, I just keep getting confused about Git* UI. |
jaro-sevcik
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
build-jax.sh --sm allwould cause XLA to emit 9.0a, which cannot be PTX JIT compiled to 10.0 and beyond.This is due to logic in XLA:
https://github.com/openxla/xla/blob/6b470af69810d93411ac8c83e476eeee84031432/third_party/tsl/third_party/gpus/cuda/hermetic/cuda_configure.bzl#L129-L193
that it not aware of the semantics of the arch-conditional (
asuffix) architectures (and a lexicographic sort where a numerical one is needed).This means that
--sm allwill produce binaries that do not support pre-Turing architectures, see https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html#deprecated-architectures.