fix: Add a dedicated service for accounting prometheus#896
Merged
Conversation
3 tasks
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
itsomri
force-pushed
the
omric/add-explicit-prometheus-service
branch
from
c1cfaac to
c47f216
Compare
davidLif
previously approved these changes
Jan 20, 2026
davidLif
force-pushed
the
omric/add-explicit-prometheus-service
branch
from
c47f216 to
32642ec
Compare
itsomri
force-pushed
the
omric/add-explicit-prometheus-service
branch
from
32642ec to
c47f216
Compare
gshaibi
approved these changes
Jan 20, 2026
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a dedicated service for the prometheus instance, instead of relying on the default service that's created by the prometheus operator - this is to avoid collisions with other prometheus instances that might be deployed on the kai-scheduler namespace
Checklist