Skip to content

minor code cleanup#916

Merged
cliffburdick merged 1 commit into
NVIDIA:mainfrom
aartbik:bik
Mar 13, 2025
Merged

minor code cleanup#916
cliffburdick merged 1 commit into
NVIDIA:mainfrom
aartbik:bik

Conversation

@aartbik
Copy link
Copy Markdown
Collaborator

@aartbik aartbik commented Mar 12, 2025

No description provided.

@aartbik aartbik requested a review from cliffburdick March 12, 2025 23:15
@cliffburdick
Copy link
Copy Markdown
Collaborator

/build

@cliffburdick
Copy link
Copy Markdown
Collaborator

Unit test is failing:

[----------] 3 tests from MatmulSparseTestsAll/1, where TypeParam = cuda::std::__4::tuple<matx::matxHalf<__nv_bfloat16>, matx::cudaExecutor>
[ RUN      ] MatmulSparseTestsAll/1.MatmulCOO
 ** On entry to cusparseSpMM_bufferSize() parameter number 6 (matB) had an illegal value: CUDA_R_16BF (__nv_bfloat16) is not supported on GPUs with compute capability < 8.0 (current: 7.5)

@aartbik
Copy link
Copy Markdown
Collaborator Author

aartbik commented Mar 13, 2025

That's strange, and certainly not related to this PR

But do we have a mixture of testing machines?

capability < 8.0 (current: 7.5)

Does MatX have a minimum capability requirement? If so, we need more guards I think

@cliffburdick
Copy link
Copy Markdown
Collaborator

/build

@cliffburdick
Copy link
Copy Markdown
Collaborator

That's strange, and certainly not related to this PR

But do we have a mixture of testing machines?

capability < 8.0 (current: 7.5)

Does MatX have a minimum capability requirement? If so, we need more guards I think

We should work on >= 7.0. Would be good to eventually see why 7.5 is not working for this.

@aartbik
Copy link
Copy Markdown
Collaborator Author

aartbik commented Mar 13, 2025

Agreed. I will follow up to avoid this:

CUDA_R_16BF (__nv_bfloat16) is not supported on GPUs with compute capability < 8.0 (current: 7.5)

@cliffburdick cliffburdick merged commit af98475 into NVIDIA:main Mar 13, 2025
@cliffburdick cliffburdick deleted the bik branch March 13, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants