Allow float for repetitions#56
Merged
philipp-fischer merged 14 commits intodevelopfrom Feb 7, 2025
Merged
Conversation
voegtlel
requested changes
Feb 6, 2025
Collaborator
voegtlel
left a comment
voegtlel
left a comment
There was a problem hiding this comment.
Of course, this needs tests. Cases I see:
- An odd-length dataset, ratio being separative
- An even-length dataset, where the ratio is exactly on the boundary (e.g. 10 samples in the dataset, 0.5 repetitions)
- Save iteration, border cases: Save just before the last sample of a repetition, and right after.
voegtlel
requested changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow not just integer repeat count but also float. That means a dataset with
0.5repetitions would end after half the dataset. Also2.5would be possible for two and a half epochs.