Feature/parallelism#72
Merged
philipp-fischer merged 6 commits intodevelopfrom Feb 18, 2025
Merged
Conversation
voegtlel
reviewed
Feb 17, 2025
voegtlel
reviewed
Feb 17, 2025
voegtlel
requested changes
Feb 18, 2025
Co-authored-by: Lukas Voegtle <5764745+voegtlel@users.noreply.github.com>
voegtlel
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix global state save/restore and improve docs around save/restore in distributed setting. Addresses #71
Also remove the src_rank argument from
restore_state_global, since that would not work with tensor parallelism.