Add prefetch_factor arg for loader#83
Merged
philipp-fischer merged 8 commits intodevelopfrom Mar 12, 2025
Merged
Conversation
voegtlel
requested changes
Mar 6, 2025
Collaborator
voegtlel
left a comment
voegtlel
left a comment
There was a problem hiding this comment.
The n_checkpoints argument is dependent of the prefetch_factor. We should assert that the number matches.
Collaborator
Author
Done @lvoegtle |
voegtlel
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some use cases, the user needs to fine tune the
prefetch_factorargument of the underlying pytorch dataloader. This PR allows to specify the arg when callingget_loaderorget_savable_loader