Skip to content

[DEV] remove training dependency from megatron core for fsdp checkpoint with EP#2114

Merged
ananthsub merged 1 commit intoNVIDIA:devfrom
ananthsub:dev-rm-training-dep-fsdpckpt
Nov 4, 2025
Merged

[DEV] remove training dependency from megatron core for fsdp checkpoint with EP#2114
ananthsub merged 1 commit intoNVIDIA:devfrom
ananthsub:dev-rm-training-dep-fsdpckpt

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Nov 3, 2025

What does this PR do ?

Corresponding PR to main branch: #2113

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

…nt with EP

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ananthsub
Copy link
Contributor Author

/ok to test 39488ab

@ko3n1g ko3n1g added this to the Core 0.16 milestone Nov 3, 2025
@ananthsub ananthsub marked this pull request as ready for review November 3, 2025 23:38
@ananthsub ananthsub requested review from a team as code owners November 3, 2025 23:38
Copy link
Contributor

@BoxiangW BoxiangW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

@ananthsub ananthsub enabled auto-merge November 4, 2025 00:06
@ananthsub ananthsub modified the milestones: Core 0.16, Core 0.15 Nov 4, 2025
@ananthsub ananthsub added this pull request to the merge queue Nov 4, 2025
Merged via the queue into NVIDIA:dev with commit 09abfad Nov 4, 2025
45 checks passed
@ananthsub ananthsub deleted the dev-rm-training-dep-fsdpckpt branch November 4, 2025 07:21
ananthsub added a commit to ananthsub/Megatron-LM that referenced this pull request Nov 5, 2025
…nt with EP (NVIDIA#2114)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ko3n1g added a commit that referenced this pull request Nov 6, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants