Skip to content

[Dev] Optimize TE CUDA Graph _get_sample_arguments() Time#2568

Merged
yaox12 merged 6 commits intoNVIDIA:devfrom
buptzyb:robinz/get_sample_arguments
Dec 17, 2025
Merged

[Dev] Optimize TE CUDA Graph _get_sample_arguments() Time#2568
yaox12 merged 6 commits intoNVIDIA:devfrom
buptzyb:robinz/get_sample_arguments

Conversation

@buptzyb
Copy link
Copy Markdown
Contributor

@buptzyb buptzyb commented Dec 5, 2025

What does this PR do ?

main PR #2392

Optimize _get_sample_arguments() time by not generating static inputs when it's not necessary.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb buptzyb requested review from a team as code owners December 5, 2025 12:45
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Dec 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@buptzyb buptzyb mentioned this pull request Dec 5, 2025
6 tasks
@buptzyb buptzyb self-assigned this Dec 5, 2025
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 5, 2025

/ok to test fc22287

Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 8, 2025

/ok to test 72b90af

Signed-off-by: Robin Zhang <robinz@nvidia.com>
assert (
sample_args[reuse_fwd_idx] is not None
and sample_kwargs[reuse_fwd_idx] is not None
), "sample_args and sample_kwargs must not be None when reusing."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add more debug info here? such as f"sample_args and sample_kwargs must not be None when reusing. reuse_fwd_idx={reuse_fwd_idx}, sample_keys={sample_keys}"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 11, 2025

/ok to test 2352e50

@buptzyb buptzyb added core_dev_r0.15.0 dev branch Dev branch related issues and development labels Dec 11, 2025
@buptzyb buptzyb requested review from yanring and yaox12 December 11, 2025 04:08
@buptzyb buptzyb added the Final Review PR is in the "final review" stage label Dec 12, 2025
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 16, 2025

/ok to test daed550

@yaox12 yaox12 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into NVIDIA:dev with commit 288b8ea Dec 17, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants