Skip to content

Conversation

@ArEsKay3
Copy link
Contributor

@ArEsKay3 ArEsKay3 commented Jan 27, 2026

What does this PR do ?

This changes the RL loop to use the new inference server code that implements an OpenAI-esque API.
As a result we no longer need to worry about chat templating in the RL code (so all of that is removed).
Also, since the "non-chat" mode is a special case of the "chat" mode switch all RL code to use messages and add a fallback template that just concatenates requests.
In order to support output parsing it adds a new Parser class that takes a string and returns the remaining string and the processed metadata. Each inference library has their own versions of these, so we need our own. In the future hopefully we can rely on HF tokenizers like we do for chat templating.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ArEsKay3
Copy link
Contributor Author

Two things I still need to clean up

  • Countdown and Math environments want to control their prompt based on what stage of alignment the model is at (chat_mode). I think we should throw this away?
  • We are not properly using the "n" argument to generation backend anymore. I want to move to use it where possible.

Copy link
Contributor

@yobibyte yobibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much cleaner now. Let me merge #2966 , and then I will merge main into this and work on nemogym support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will require adjusting of just recipes.

@ArEsKay3 ArEsKay3 marked this pull request as ready for review February 4, 2026 04:23
@ArEsKay3 ArEsKay3 requested review from a team as code owners February 4, 2026 04:23
@ko3n1g ko3n1g requested a review from a team February 4, 2026 04:23
@tdene
Copy link
Contributor

tdene commented Feb 12, 2026

/ok to test 6baad1e

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21932262559

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@tdene
Copy link
Contributor

tdene commented Feb 12, 2026

/ok to test 14be3e1

@tdene tdene added this pull request to the merge queue Feb 12, 2026
@tdene tdene removed this pull request from the merge queue due to a manual request Feb 12, 2026
@tdene tdene added this pull request to the merge queue Feb 12, 2026
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21960186453

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@tdene tdene added this pull request to the merge queue Feb 12, 2026
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21962433107

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@tdene tdene added this pull request to the merge queue Feb 12, 2026
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21965383906

@ko3n1g ko3n1g removed this pull request from the merge queue due to a manual request Feb 12, 2026
@ko3n1g ko3n1g merged commit 1123fc0 into NVIDIA:main Feb 12, 2026
46 checks passed
ko3n1g added a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.