-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Move to using the Inference OpenAI API server #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to using the Inference OpenAI API server #3107
Conversation
…e request record merge
|
Two things I still need to clean up
|
yobibyte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much cleaner now. Let me merge #2966 , and then I will merge main into this and work on nemogym support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will require adjusting of just recipes.
.../core/inference/text_generation_server/dynamic_text_gen_server/endpoints/chat_completions.py
Outdated
Show resolved
Hide resolved
|
/ok to test 6baad1e |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21932262559 |
|
/ok to test 14be3e1 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21960186453 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21962433107 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21965383906 |
What does this PR do ?
This changes the RL loop to use the new inference server code that implements an OpenAI-esque API.
As a result we no longer need to worry about chat templating in the RL code (so all of that is removed).
Also, since the "non-chat" mode is a special case of the "chat" mode switch all RL code to use messages and add a fallback template that just concatenates requests.
In order to support output parsing it adds a new Parser class that takes a string and returns the remaining string and the processed metadata. Each inference library has their own versions of these, so we need our own. In the future hopefully we can rely on HF tokenizers like we do for chat templating.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.